Commits
Marek Vsechovsky committed 3f97ecbff1b
Session 196, Step 2: Handle renumbered statuses and Deferred by AI in output-file validation - AIM-3694 Handle renumbered statuses and Deferred by AI in output-file validation Outcome: **AIM-3694** reworked per the user's correction (n2): the step-1 suppression of the skipped/deferred-language warning was replaced by **two separate warnings** in the output-file validation of `wwwroot/js/dashboard/dashboard-project.js`. 1. Issues set to the **Deferred by AI** status (`IssueImplementationStatusEnum.DeferredByAi`, `status: 2`) are still **reported as skipped** — with the message that nothing should ideally be skipped — and are reported even when their result contains no deferred language. 2. The original *deferred/skipped language* warning now fires only for the remaining issues (those without the Deferred by AI status), so no issue is double-reported. The renumbered status messages from step 1 (`status: 3` = Implemented by AI, `status: 2` = Deferred by AI) were verified unchanged. The step-1 test that asserted suppression was rewritten to pin the two-warning behavior (declared deferral → skipped warning; undeclared language → original warning; mutually exclusive); `node --test tests/dashboard-validation.test.cjs` passes 11/12 — the single failure is a pre-existing duration-format expectation untouched by this change. `aisman-instructions-template.md` and `.aisman/project-memory/aisman-workflow.md` no longer claim that validation accepts deferred language for `status: 2`. --- Session 196, Step 3: Handle renumbered statuses and Deferred by AI in output-file validation - AIM-3694 Handle renumbered statuses and Deferred by AI in output-file validation Outcome: **AIM-3694** — steering follow-up addressed with the *minus-plus-announcement* design. - **Verified:** both warning categories generate in a single validation pass. The `else if` chain runs per issue inside `parsed.issues.forEach`; a mixed file (status 2 + language, language-only, status-2-only, clean) yields the Deferred-by-AI skipped warning for the status issues and the deferred-language warning for the undeclared issue in one pass — no category is suppressed file-wide. Pinned by a new regression test. - **Announced:** the deferred-language warning now says up front that declaring `status: 2` does not silence validation — the issue stays reported as skipped on every re-check (nothing should ideally be skipped) — so acting on it can never reveal a message absent from the first pass. - The n2 "minus" rule is preserved (status-2 issue → skipped warning only, with its language marker quoted). Tests: 12/13 pass, the single failure being the pre-existing duration-format test at HEAD. Project memory updated; the instructions template already tells agents declared deferrals still warn. --- Session 196, Step 4: Assess harness memories file and align the critical rule with project memory - AIM-3695 Assess harness memories file and align the critical rule with project memory Outcome: **Issue -4344, first part** — the user's decision and follow-up requirements continue in step 5: - Verified the origin of `memories/aisman-critical-rule-output-files.md`: Phase-0 mandate in `.aisman/instructions.md` + the `11-memory-init.md` table's Copilot mapping, against an empty workspace `memories/` folder that pre-existed since 2026-10-23. - Checked coverage against `.aisman/project-memory/`: the critical rule, workflow phases and output-file location were already there; added the missing pieces — **Direct-session specifics** (ds_ naming, one-chat-one-session, negative `session.num`, verbatim `inputText`, catalog temp numbers) and **Output-file discipline** (why the output file is sacred, ask-first for simple direct requests, harness copies are duplicate reminders with user decisions recorded) — and refreshed the README index. - Explained the rationale to the user and asked whether to keep the harness-level copy. --- Session 196, Step 5: Verify the real Copilot memory location and clarify the memory-init template guidance - AIM-3695 Assess harness memories file and align the critical rule with project memory Outcome: **Issue -4344, second part — resolved:** the workspace `memories/` folder was NOT a GitHub Copilot standard location, so per the user's directive the content was moved to the one place Copilot demonstrably reads — its memory-tool store in VS Code globalStorage (which already held the rule from earlier sessions, in outdated wording). The merged file keeps the two accumulated lessons from the old copy. The `11-memory-init` template table is now explicitly examples-only (Copilot row corrected to the verified store) and project memory records the verified path, the removal of the workspace copy, and the Phase-0 check for tool-less sessions. Findings: Copilot-harness memory is cloud **Copilot Memory** by default; experimental repo store `.github/copilot-memories.jsonl`; `.github/memories/` does not exist as a standard.